Manual colors not working

Posts that are done/fixed/closed or aged! for this section are placed in here to keep the forum in shape & more viewable!
Locked [phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable
User avatar
Phoenix
ECC Developer 2006-2016
Posts: 9059
Joined: 27 Aug 2006, 01:17
Location: Deventer, The Netherlands
Contact:

Manual colors not working

Unread post by Phoenix » 07 May 2014, 21:10

It seems that the manual settings of colors do not work, since they are overwritten bij the 'theme default' color INI:

Code: Select all

\ecc-themes\[THEME]\themeColors.ini
and since we don't have the 'none' theme anymore, the colors in the config aren't working anymore...

Working on this issue!
Sebastiaan Ebeltjes | ECC Developer 2006-2016 | ECC Forum Admin | Phoenix Interactive WebMaster
[- ECC programs -]
eccUpdate, eccScriptSystem, GtkThemeSelect, DatFileUpdater (DFU), ImagePackCenter (IPC), eccDiagnostics, 3dGallery, iccImageInject
eccKameleonCode, eccCreateStartmenuShotcut, eccThirdPartyConfig (TPC), EmuMoviesDownloader (EMD), eccVideoPlayer
MobyGamesImporter (MGI), ECC Amiga GetGemusConfig.

User avatar
Phoenix
ECC Developer 2006-2016
Posts: 9059
Joined: 27 Aug 2006, 01:17
Location: Deventer, The Netherlands
Contact:

Re: Manual colors not working

Unread post by Phoenix » 07 May 2014, 21:13

I've found the line (ecc.php around line 750) where ECC loads the 'theme colors INI' instead of the manual colors (in GENERAL INI)

Code: Select all

FACTORY::get('manager/IniFile')->setThemColors(FACTORY::get('manager/GuiTheme')->getColorIniPath());
to overide it we need a config setting...
Sebastiaan Ebeltjes | ECC Developer 2006-2016 | ECC Forum Admin | Phoenix Interactive WebMaster
[- ECC programs -]
eccUpdate, eccScriptSystem, GtkThemeSelect, DatFileUpdater (DFU), ImagePackCenter (IPC), eccDiagnostics, 3dGallery, iccImageInject
eccKameleonCode, eccCreateStartmenuShotcut, eccThirdPartyConfig (TPC), EmuMoviesDownloader (EMD), eccVideoPlayer
MobyGamesImporter (MGI), ECC Amiga GetGemusConfig.

User avatar
Phoenix
ECC Developer 2006-2016
Posts: 9059
Joined: 27 Aug 2006, 01:17
Location: Deventer, The Netherlands
Contact:

Re: Manual colors not working

Unread post by Phoenix » 07 May 2014, 21:16

I am building an option in the ECC config wherether to use the 'theme colors' or your 'manual colors' :swing:
Attachments
ecc_config_themecolors.png
Sebastiaan Ebeltjes | ECC Developer 2006-2016 | ECC Forum Admin | Phoenix Interactive WebMaster
[- ECC programs -]
eccUpdate, eccScriptSystem, GtkThemeSelect, DatFileUpdater (DFU), ImagePackCenter (IPC), eccDiagnostics, 3dGallery, iccImageInject
eccKameleonCode, eccCreateStartmenuShotcut, eccThirdPartyConfig (TPC), EmuMoviesDownloader (EMD), eccVideoPlayer
MobyGamesImporter (MGI), ECC Amiga GetGemusConfig.

User avatar
Phoenix
ECC Developer 2006-2016
Posts: 9059
Joined: 27 Aug 2006, 01:17
Location: Deventer, The Netherlands
Contact:

Re: Manual colors not working

Unread post by Phoenix » 07 May 2014, 21:35

OK, config settings read/write are tested and working! :thumb:

cGuiPopConfig.php around line 290 (SET ICON):

Code: Select all

$this->imgUseThemeColors->set_from_file(FACTORY::get('manager/GuiTheme')->getThemeFolder('icon/ecc_config_color_picker.png'));

cGuiPopConfig.php around line 1060 (SET TRANSLATION):

Code: Select all

		// ECC v1.152 Build 06
		$this->lblUseThemeColors->set_text(I18N::get('popupConfig', 'lblUseThemeColors'));

cGuiPopConfig.php around line 1120 (READ VALUES FOR CONFIG):

Code: Select all

// ECC v1.152 Build 06
$cfgUseThemeColors = $iniManager->getKey('ECC_THEME', 'use_theme_colors');
$this->cfgUseThemeColors->set_active($cfgUseThemeColors);
cGuiPopConfig.php around line 1245 (SAVE VALUES TO INI):

Code: Select all

$this->globalIni['ECC_THEME']['use_theme_colors'] = $this->cfgUseThemeColors->get_active();
new icon:
ecc_config_color_picker.png
ecc_config_color_picker.png (2.64 KiB) Viewed 897 times
Sebastiaan Ebeltjes | ECC Developer 2006-2016 | ECC Forum Admin | Phoenix Interactive WebMaster
[- ECC programs -]
eccUpdate, eccScriptSystem, GtkThemeSelect, DatFileUpdater (DFU), ImagePackCenter (IPC), eccDiagnostics, 3dGallery, iccImageInject
eccKameleonCode, eccCreateStartmenuShotcut, eccThirdPartyConfig (TPC), EmuMoviesDownloader (EMD), eccVideoPlayer
MobyGamesImporter (MGI), ECC Amiga GetGemusConfig.

User avatar
Phoenix
ECC Developer 2006-2016
Posts: 9059
Joined: 27 Aug 2006, 01:17
Location: Deventer, The Netherlands
Contact:

Re: Manual colors not working

Unread post by Phoenix » 09 May 2014, 08:32

Changed in ecc.php around line 730 (TRIGGER):

Code: Select all

		// TRIGGER - THEME COLORS LOADING? | config setting: use_theme_colors | added 2014-05-09
		$use_theme_colors = $this->ini->getKey('ECC_THEME', 'use_theme_colors');
		if ($use_theme_colors == "1"){
		// Load and overwrite ECC theme 'user setting' (GENERAL.INI) with the theme settings in 'ecc-themes\[THEME]\themeColors.ini'
			FACTORY::get('manager/IniFile')->setThemColors(FACTORY::get('manager/GuiTheme')->getColorIniPath());
		}
Sebastiaan Ebeltjes | ECC Developer 2006-2016 | ECC Forum Admin | Phoenix Interactive WebMaster
[- ECC programs -]
eccUpdate, eccScriptSystem, GtkThemeSelect, DatFileUpdater (DFU), ImagePackCenter (IPC), eccDiagnostics, 3dGallery, iccImageInject
eccKameleonCode, eccCreateStartmenuShotcut, eccThirdPartyConfig (TPC), EmuMoviesDownloader (EMD), eccVideoPlayer
MobyGamesImporter (MGI), ECC Amiga GetGemusConfig.

User avatar
Phoenix
ECC Developer 2006-2016
Posts: 9059
Joined: 27 Aug 2006, 01:17
Location: Deventer, The Netherlands
Contact:

Re: Manual colors not working

Unread post by Phoenix » 09 May 2014, 10:30

This feature has been added in update 00604: viewtopic.php?f=28&t=5147

Enjoy!
Sebastiaan Ebeltjes | ECC Developer 2006-2016 | ECC Forum Admin | Phoenix Interactive WebMaster
[- ECC programs -]
eccUpdate, eccScriptSystem, GtkThemeSelect, DatFileUpdater (DFU), ImagePackCenter (IPC), eccDiagnostics, 3dGallery, iccImageInject
eccKameleonCode, eccCreateStartmenuShotcut, eccThirdPartyConfig (TPC), EmuMoviesDownloader (EMD), eccVideoPlayer
MobyGamesImporter (MGI), ECC Amiga GetGemusConfig.

Locked
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable
[phpBB Debug] PHP Warning: in file [ROOT]/vendor/twig/twig/lib/Twig/Extension/Core.php on line 1266: count(): Parameter must be an array or an object that implements Countable

Who is online

Users browsing this forum: No registered users and 1 guest